Skip to content

Fix vulnerable System.Security.Cryptography.Xml via updating Microsoft.Extensions to 10.0.7 - #1260

Merged
paulirwin merged 2 commits into
apache:masterfrom
paulirwin:fix/vulnerable-package-warnings
Apr 23, 2026
Merged

Fix vulnerable System.Security.Cryptography.Xml via updating Microsoft.Extensions to 10.0.7#1260
paulirwin merged 2 commits into
apache:masterfrom
paulirwin:fix/vulnerable-package-warnings

Conversation

@paulirwin

@paulirwin paulirwin commented Apr 15, 2026

Copy link
Copy Markdown
Contributor
  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Fixes a vulnerability warning with System.Security.Cryptography.Xml

Description

Updates Microsoft.Extensions libraries to 10.0.7 to fix a transitive vulnerability: GHSA-37gx-xxp4-5rgx

@paulirwin paulirwin added the notes:bug-fix Contains a fix for a bug label Apr 15, 2026
@paulirwin
paulirwin marked this pull request as draft April 16, 2026 12:45
@paulirwin

paulirwin commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author

Due to reports of incompatibilities with ASP.NET Core Data Protection (see dotnet/aspnetcore#66335), converting this to draft until it's confirmed stable (sounds like that will be in 10.0.7).

Note that any users affected can still override the installed version of this package manually to address the vulnerability concern, particularly if they are not using ASP.NET Core Data Protection. This is not a vulnerability in our library.

Edit: We are currently using 8.0.3 in this PR, not 10.0.6, but out of caution I'm still going to hold off a few days just in case there are users regularly running off latest master. I am unsure if the effect is the same for ASP.NET Core Data Protection 8.x. Also, separately I will look into upgrading our packages from 8.x to 10.x after this is merged.

@paulirwin
paulirwin force-pushed the fix/vulnerable-package-warnings branch from 15438bd to 7e5057f Compare April 22, 2026 18:17
@paulirwin paulirwin changed the title Fix vulnerable version of System.Security.Cryptography.Xml Fix vulnerable System.Security.Cryptography.Xml via updating Microsoft.Extensions to 10.0.7 Apr 22, 2026
@paulirwin

Copy link
Copy Markdown
Contributor Author

10.0.7 was released with the regression fix, and it pulls in the vulnerability-fixed version of System.Security.Cryptography.Xml transitively, so I went ahead and upgraded all of our Microsoft.Extensions libraries to be on the same 10.0.7 version. That let me remove the manual installation of this package from the prior commit.

Note that just like the 8.x versions of the Microsoft.Extensions packages, the 10.x versions support netstandard2.0 and net462 just like our baseline targets.

@paulirwin
paulirwin marked this pull request as ready for review April 22, 2026 18:24
@paulirwin
paulirwin requested a review from Copilot April 22, 2026 18:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the centralized NuGet package version properties to address a transitive vulnerability warning involving System.Security.Cryptography.Xml by bumping Microsoft.Extensions.* package versions.

Changes:

  • Introduces a single MicrosoftExtensionsParentVersion property and updates related Microsoft.Extensions.* version properties to 10.0.7.
  • Aligns the previously mixed 8.0.0/8.0.1 Microsoft.Extensions.* versions to a single version value.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .build/dependencies.props

@NightOwl888 NightOwl888 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@paulirwin
paulirwin merged commit 9a1bf2e into apache:master Apr 23, 2026
215 checks passed
@paulirwin
paulirwin deleted the fix/vulnerable-package-warnings branch April 23, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notes:bug-fix Contains a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants